Flink: Add possibilit of ordering the splits based on the file sequence number #7661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenzwu
reviewed
Jun 1, 2023
.../v1.17/flink/src/main/java/org/apache/iceberg/flink/source/assigner/SortedSplitAssigner.java
Outdated
Show resolved
Hide resolved
|
|
||
| /** Simple assigner only tracks unassigned splits */ | ||
| @Override | ||
| public synchronized Collection<IcebergSourceSplitState> state() { |
Contributor
There was a problem hiding this comment.
if we go with the new approach on watermark alignment, IcebergSourceSplitState is probably not needed. this can be Collection<IcebergSourceSplit> pendingSplits(). It can be a separate PR to not distract the purpose of this PR.
Contributor
Author
There was a problem hiding this comment.
Wouldn't we still need the state to store the current read positions at savepoints/checkpoints?
Contributor
There was a problem hiding this comment.
IcebergSourceSplitState class just wrapped IcebergSourceSplit with a status flag (like UNASSIGNED, ASSIGNED). the flag was introduced for the watermark alignment assigner, as it needs to track the ASSIGNED (and not completed) splits in addition to the pending UNASSIGNED splits. With the new approach of leveraging Flink for watermark tracking/aggregation, we only need to track pending UNASSIGNED splits.
...k/src/main/java/org/apache/iceberg/flink/source/split/FileSequenceNumberBasedComparator.java
Outdated
Show resolved
Hide resolved
...k/src/main/java/org/apache/iceberg/flink/source/split/FileSequenceNumberBasedComparator.java
Outdated
Show resolved
Hide resolved
…itAssigner, checks/messages
stevenzwu
reviewed
Jun 5, 2023
...k/src/main/java/org/apache/iceberg/flink/source/split/FileSequenceNumberBasedComparator.java
Outdated
Show resolved
Hide resolved
...link/src/main/java/org/apache/iceberg/flink/source/assigner/DefaultSplitAssignerFactory.java
Outdated
Show resolved
Hide resolved
...k/src/main/java/org/apache/iceberg/flink/source/split/FileSequenceNumberBasedComparator.java
Outdated
Show resolved
Hide resolved
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java
Outdated
Show resolved
Hide resolved
stevenzwu
reviewed
Jun 8, 2023
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java
Show resolved
Hide resolved
...link/src/main/java/org/apache/iceberg/flink/source/assigner/OrderedSplitAssignerFactory.java
Outdated
Show resolved
Hide resolved
...k/src/main/java/org/apache/iceberg/flink/source/split/FileSequenceNumberBasedComparator.java
Outdated
Show resolved
Hide resolved
...flink/src/main/java/org/apache/iceberg/flink/source/assigner/SimpleSplitAssignerFactory.java
Outdated
Show resolved
Hide resolved
...k/src/main/java/org/apache/iceberg/flink/source/split/FileSequenceNumberBasedComparator.java
Outdated
Show resolved
Hide resolved
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/SplitHelpers.java
Outdated
Show resolved
Hide resolved
...1.17/flink/src/test/java/org/apache/iceberg/flink/source/reader/TestIcebergSourceReader.java
Outdated
Show resolved
Hide resolved
...1.17/flink/src/test/java/org/apache/iceberg/flink/source/reader/TestIcebergSourceReader.java
Show resolved
Hide resolved
stevenzwu
reviewed
Jun 8, 2023
...k/src/main/java/org/apache/iceberg/flink/source/split/FileSequenceNumberBasedComparator.java
Outdated
Show resolved
Hide resolved
stevenzwu
reviewed
Jun 8, 2023
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/split/SplitComparators.java
Show resolved
Hide resolved
...k/src/main/java/org/apache/iceberg/flink/source/split/FileSequenceNumberBasedComparator.java
Outdated
Show resolved
Hide resolved
stevenzwu
approved these changes
Jun 16, 2023
Contributor
|
thanks @pvary for the contribution |
Contributor
Author
|
Thanks @stevenzwu for the review! |
pvary
pushed a commit
to pvary/iceberg
that referenced
this pull request
Jun 23, 2023
…ts based on the file sequence number (apache#7661)
rodmeneses
pushed a commit
to rodmeneses/iceberg
that referenced
this pull request
Feb 19, 2024
rodmeneses
pushed a commit
to rodmeneses/iceberg
that referenced
this pull request
Feb 19, 2024
…ts based on the file sequence number (apache#7661) (apache#7889)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flink users often depend on the fact that the IcebergSource reads the Iceberg snapshots in the same order as they were committed. This assumption could be broken on job start or job restart when multiple snapshots are read in one planning cycle.
To ensure that the splits are ordered as expected the PR adds FileSequenceNumberBasedSplitAssignerFactory where the splits are ordered based on the ContentFile.fileSequenceNumber().