-
Notifications
You must be signed in to change notification settings - Fork 3k
Implement ReadableMetrics for Entries table #7539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
szehon-ho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, just some comments about code - reuse
|
Merged, thanks @dramaticlly for the change! |
|
Hi, @dramaticlly as I didnt want to block the change, I had some follow up that I made in #7613 including what we discussed in #7539 (comment). I think it makes the code between BaseFilesTable and BaseEntriesTable even more similar and with more re-use, if you wanted to take a look |
|
Hello, I want to get upper/lower bounds from the manifest file like: The log will be byteBuffer, I see @szehon-ho pr for a readable metrics, I am wondering do we have a java api we can use, or I have to use DDL? |
close #7364
This enable query readable metrics on entry metadata table, similar to #5376 by @szehon-ho
Given table schema like below
we can query its per column min/max for each manifest entry