[ORC][Spark] - Support selected vector with ORC reader on the row and batch reader #7197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaani
reviewed
Mar 28, 2023
| InternalRow row = rows.next(); | ||
| Assertions.assertEquals(3L, row.getLong(0)); | ||
| Assertions.assertEquals("c", row.getString(1)); | ||
| Assertions.assertArrayEquals(new int[] {3, 4, 5}, row.getArray(3).toIntArray()); |
Contributor
There was a problem hiding this comment.
hi @pavibhai there was a recommendation to use assertj for assertions - https://github.com/apache/iceberg/blob/master/CONTRIBUTING.md#assertj
Contributor
Author
There was a problem hiding this comment.
Thanks for calling that out
dpaani
reviewed
Mar 28, 2023
|
|
||
| protected int getRowIndex(int rowId) { | ||
| return vector.isRepeating ? 0 : rowId; | ||
| int row = isSelectedInUse ? selected[rowId] : rowId; |
Contributor
There was a problem hiding this comment.
will there be a possibility of isSelectedInUse=true and selected is empty?
Contributor
Author
There was a problem hiding this comment.
No, this is not a possibility. Similar to other vectors the selected vector is initialized at the start to max batch size and all of the indices in this are excepted to be within that size.
aokolnychyi
approved these changes
Apr 15, 2023
Contributor
|
Thanks, @pavibhai! |
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently Iceberg does not support the use of the selected vector when reading ORC Files. This requires reads on ORC to be run in compatibility mode by not setting
orc.filter.use.selectedin the presence of filter processing that is triggered viaorc.sarg.to.filter.Filter processing was introduced as part of ORC-744 where ORC has the ability to filter out records and indicate this status in partially filtered batches using the selected vector in VectorizedRowBatch.
This PR uses the selected vector to determine valid rows when applicable.
Why?
ORC can only operate in compatibility mode by not setting
orc.filter.use.selected. Enabling this will further hasten the processing of rows by ignoring rows that are already filtered out in the batch.Tested?
New Unit tests have been added to verify the behavior.