Skip to content

Fix TestAggregateBinding #6065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rdblue merged 2 commits into from
Nov 6, 2022
Merged

Fix TestAggregateBinding #6065

rdblue merged 2 commits into from
Nov 6, 2022

Conversation

@huaxingao
Copy link
Contributor

@huaxingao huaxingao commented Oct 27, 2022 •
edited
Loading

@github-actions github-actions bot added the API label Oct 27, 2022
@huaxingao huaxingao mentioned this pull request Oct 27, 2022
Merged
nastra
nastra reviewed Oct 27, 2022
View reviewed changes
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for following up with this, I left one comment around generic type paramter usage

api/src/test/java/org/apache/iceberg/expressions/TestAggregateBinding.java Outdated
public class TestAggregateBinding {
private static final List<Expression.Operation> AGGREGATES =
Arrays.asList(Expression.Operation.COUNT, Expression.Operation.MAX, Expression.Operation.MIN);
private static final List<UnboundAggregate> list =
Copy link
Contributor

@nastra nastra Oct 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that in this entire file we're using UnboundAggregate without specifying a generic type. I think it would be good to replace all UnboundAggregate by UnboundAggregate<String>? Same for BoundAggregate, which should probably be BoundAggregate<String, String>

Copy link
Contributor Author

@huaxingao huaxingao Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks! I accidentally put String type in the factory methods. It should be T. I fixed that.

nastra
nastra approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for fixing. I think the only other thing left is adjusting the ExpressionParser + TestExpressionParser

@huaxingao
Copy link
Contributor Author

huaxingao commented Oct 28, 2022

@rdblue Could you please take a look when you have a moment? Thanks a lot!

@rdblue rdblue merged commit bcd1518 into apache:master Nov 6, 2022
@rdblue
Copy link
Contributor

rdblue commented Nov 6, 2022

Thanks, @huaxingao!

@huaxingao
Copy link
Contributor Author

huaxingao commented Nov 6, 2022

Thanks! @rdblue @nastra @Fokko

@huaxingao huaxingao deleted the follow-up branch November 6, 2022 23:31
zhongyujiang pushed a commit to zhongyujiang/iceberg that referenced this pull request Apr 16, 2025
@huaxingao @XIAOMIlipeidian
API: Fix TestAggregateBinding (apache#6065)
6e30aea 
(cherry picked from commit bcd1518)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdblue rdblue rdblue approved these changes

@nastra nastra nastra approved these changes

@Fokko Fokko Fokko approved these changes

Assignees

No one assigned

Labels

API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huaxingao @rdblue @nastra @Fokko