Core: Fix exception handling in BaseTaskWriter #5683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
commented
Aug 31, 2022
| if (!closed) { | ||
| flushDeletes(); | ||
| this.closed = true; | ||
| flushDeletes(); |
Contributor
Author
There was a problem hiding this comment.
Fixes double close here as well.
rdblue
commented
Aug 31, 2022
| public List<DeleteFile> complete() throws IOException { | ||
| close(); | ||
|
|
||
| Preconditions.checkState(failure != null, "Cannot return results from failed writer", failure); |
Contributor
Author
There was a problem hiding this comment.
This implements the same logic as in BaseTaskWriter: if there was an exception while writing the file, don't allow complete to succeed.
danielcweeks
approved these changes
Sep 1, 2022
rdblue
added a commit
to rdblue/iceberg
that referenced
this pull request
Sep 2, 2022
* Core: Fix exception handling in BaseTaskWriter. * Fix state check.
rdblue
added a commit
to rdblue/iceberg
that referenced
this pull request
Sep 2, 2022
* Core: Fix exception handling in BaseTaskWriter. * Fix state check.
rdblue
added a commit
to rdblue/iceberg
that referenced
this pull request
Sep 2, 2022
* Core: Fix exception handling in BaseTaskWriter. * Fix state check.
rdblue
added a commit
that referenced
this pull request
Sep 3, 2022
* Core: Fix exception handling in BaseTaskWriter. * Fix state check.
sunchao
pushed a commit
to sunchao/iceberg
that referenced
this pull request
May 10, 2023
* Core: Fix exception handling in BaseTaskWriter. * Fix state check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative fix for the Flink double close problem, #4168 and #5310.
The original solution modified
S3OutputStreamso that every call tocloseafter a failure would re-throw the original exception. That violates the contract forclose, which states:The original fix also did not address the underlying problem that the stream was closed twice and still emitting data files. This PR fixes double close cases in
BaseTaskWriterby ensuring the writer that is closed is always set to null.This PR also attempts to fix the problem of duplicate data in Flink by throwing an
IllegalStateExceptionif a call toclosefails butcompleteis still called on theBaseTaskWriter. The write result fromcompleteis the only way to emit data files, so this ensures that no data files will be emitted from a writer that failed while closing a file. This is a precaution because it isn't clear why failed Flink writers were still emitting data files.