Core: Fix ErrorProne Warnings

[nastra]

The only warning that is left is this one from

iceberg/core/src/main/java/org/apache/iceberg/util/ZOrderByteUtils.java

Lines 182 to 183 in 2f8a09a

	interleavedBytes[interleaveByte] |=
	(columnsBinary[sourceColumn][sourceByte] & 1 << sourceBit) >>> sourceBit << interleaveBit;

which seems legit as we're doing a lossy cast that would fail compilation if I rewrite it (https://errorprone.info/bugpattern/NarrowingCompoundAssignment):

> Task :iceberg-core:compileJava
/home/nastra/Development/workspace/iceberg/core/src/main/java/org/apache/iceberg/util/ZOrderByteUtils.java:182: warning: [NarrowingCompoundAssignment] Compound assignments from int to byte hide lossy casts
      interleavedBytes[interleaveByte] |=
                                       ^
    (see https://errorprone.info/bugpattern/NarrowingCompoundAssignment)
  Did you mean 'interleavedBytes[interleaveByte] = (byte) (interleavedBytes[interleaveByte] | (columnsBinary[sourceColumn][sourceByte] & 1 << sourceBit) >>> sourceBit << interleaveBit);'?

[rdblue]

Thanks, @nastra! Looks good to me.

[RussellSpitzer]

The only warning that is left is this one from

iceberg/core/src/main/java/org/apache/iceberg/util/ZOrderByteUtils.java

Lines 182 to 183 in 2f8a09a

	interleavedBytes[interleaveByte] |=
	(columnsBinary[sourceColumn][sourceByte] & 1 << sourceBit) >>> sourceBit << interleaveBit;

which seems legit as we're doing a lossy cast that would fail compilation if I rewrite it (https://errorprone.info/bugpattern/NarrowingCompoundAssignment):

> Task :iceberg-core:compileJava
/home/nastra/Development/workspace/iceberg/core/src/main/java/org/apache/iceberg/util/ZOrderByteUtils.java:182: warning: [NarrowingCompoundAssignment] Compound assignments from int to byte hide lossy casts
      interleavedBytes[interleaveByte] |=
                                       ^
    (see https://errorprone.info/bugpattern/NarrowingCompoundAssignment)
  Did you mean 'interleavedBytes[interleaveByte] = (byte) (interleavedBytes[interleaveByte] | (columnsBinary[sourceColumn][sourceByte] & 1 << sourceBit) >>> sourceBit << interleaveBit);'?

So this is as intended

The code is a bit complicated but a description would be

 interleavedBytes[interleaveByte] |=  //  if the target bit isn't set it
         (columnsBinary[sourceColumn][sourceByte] & 1 << sourceBit) >>> sourceBit  // Get the bit we are checking and move it all the way into the 1's place
<< interleaveBit;  // Move the bit back into our target position

So

(columnsBinary[sourceColumn][sourceByte] & 1 << sourceBit) 

Can only produce values between 0 and 128 (00000000), (00000001), (00000010), .... (10000000)

Then

>>> sourceBit 

Can only produce values between 0 and 1

then

<< interleaveBit

Can only produce values again between 0 and 128

Now if interleave bit or source bit were greater than 7 we would be in trouble but those are locked down

[nastra]

thanks for the clarification @RussellSpitzer. I suppressed the warning for NarrowingCompoundAssignment in #5212