AWS: support overriding endpoint in DynamoDB #4726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for this! This change looks good to me |
amogh-jahagirdar
approved these changes
May 10, 2022
aws/src/integration/java/org/apache/iceberg/aws/TestDefaultAwsClientFactory.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
requested changes
May 11, 2022
Contributor
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Sorry about that, I was doing a second pass of review, and realized that indentation in some places were off, can we double check that?
aws/src/main/java/org/apache/iceberg/aws/AssumeRoleAwsClientFactory.java
Outdated
Show resolved
Hide resolved
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java
Outdated
Show resolved
Hide resolved
3620814 to
c05d788
Compare
c05d788 to
47a9482
Compare
Contributor
Author
|
@amogh-jahagirdar Could you run workflow if you have the permission? cc: @jackye1995 |
jackye1995
reviewed
May 13, 2022
Contributor
jackye1995
left a comment
There was a problem hiding this comment.
looks good to me! enabling CI
Contributor
Author
|
@jackye1995 Gentle reminder. |
Contributor
|
Thanks, @ebyhr! Sorry for the delay. |
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes testing DynamoDB integration easily with docker (https://hub.docker.com/r/amazon/dynamodb-local/).