-
Notifications
You must be signed in to change notification settings - Fork 3k
AWS: Add S3 Tagging #4259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS: Add S3 Tagging #4259
Conversation
5e20918 to
743ab6f
Compare
53bb7fe to
dd95b29
Compare
|
I took the idea of parsing the properties beginning with a prefix from #4011 Refer method name: |
jackye1995
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic mostly looks correct to me, added some comments
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3OutputStream.java
Outdated
Show resolved
Hide resolved
43240dd to
79fb20b
Compare
singhpk234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @rajarshisarkar !!! for all the work.
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3OutputStream.java
Outdated
Show resolved
Hide resolved
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3OutputStream.java
Outdated
Show resolved
Hide resolved
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3OutputStream.java
Outdated
Show resolved
Hide resolved
jackye1995
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This change adds S3 Tags to the objects while writing using
S3FileIO. Users can pass their custom tags as part of the catalog properties.Spark SQL launch command:
Tags added in S3:
cc: @jackye1995 @arminnajafi @singhpk234 @amogh-jahagirdar @xiaoxuandev @yyanyy