Hive: Parquet vectorization support for Hive 3 #3980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvary
reviewed
Jan 26, 2022
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Jan 26, 2022
hive3/src/main/java/org/apache/iceberg/mr/hive/vector/ParquetSchemaFieldNameVisitor.java
Outdated
Show resolved
Hide resolved
marton-bod
reviewed
Jan 26, 2022
hive3/src/main/java/org/apache/iceberg/mr/hive/vector/ParquetSchemaFieldNameVisitor.java
Outdated
Show resolved
Hide resolved
marton-bod
approved these changes
Jan 26, 2022
pvary
approved these changes
Jan 26, 2022
Contributor
|
Let's see if anyone wants to comment. If not, then I can merge tomorrow |
Contributor
Author
|
I have found an issue while testing column re-addition, I'll be uploading the fix for that shortly, please don't commit yet. |
pvary
reviewed
Jan 28, 2022
hive3/src/main/java/org/apache/iceberg/mr/hive/vector/ParquetSchemaFieldNameVisitor.java
Show resolved
Hide resolved
pvary
reviewed
Jan 28, 2022
hive3/src/main/java/org/apache/iceberg/mr/hive/vector/ParquetSchemaFieldNameVisitor.java
Show resolved
Hide resolved
pvary
reviewed
Jan 28, 2022
hive3/src/main/java/org/apache/iceberg/mr/hive/vector/ParquetSchemaFieldNameVisitor.java
Outdated
Show resolved
Hide resolved
pvary
approved these changes
Jan 28, 2022
Contributor
Author
|
Thanks for the reviews and the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support or Parquet vectorization. Similarly to how this was done with ORC, we are reusing the already implemented Parquet vectorized read implementation of Hive. It is hooked into IcebergInputFormat to create the record reader from the split and fileScanTask information.
This change also reuses parts of the proposed solution in #3242 by @tprelle so that query plans that failed to get vectorized during Hive query compilation are correctly falling back to the non-vectorized read path.