Skip to content

Conversation

@vanliu-tx
Copy link
Contributor

…les in namespace

A flag is added to indicate whether to filter iceberg table in HiveCatalog#listTables method. Related to #3907

@hililiwei
Copy link
Contributor

Can it be improved if change to parallelStream?

@vanliu-tx
Copy link
Contributor Author

vanliu-tx commented Jan 17, 2022

Can it be improved if change to parallelStream?

I don't think so. Besides, in our production, we use different namespace schema for different table type. For example, tables under namespace iceberg_{biz_id} are all iceberg tables, tables under namespace hive_{biz_id} are all hive partition tables. It's wasting time for method call List<Table> tableObjects = clients.run(client -> client.getTableObjectsByName(database, tableNames)) in our env.

@vanliu-tx
Copy link
Contributor Author

@rdblue @jackye1995 could you help to review this?

@hililiwei
Copy link
Contributor

Does it only work in Hivecatalog? If so, would it be better to name 'hive.filter-iceberg-table' or 'hive.show-iceberg-table-only'?

@rdblue
Copy link
Contributor

rdblue commented Jan 17, 2022

Can it be improved if change to parallelStream?

Iceberg doesn't use streams for parallelism because they are quite limited. When parallelizing operations, be sure to use Tasks instead.

Copy link
Contributor

@rdblue rdblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this option is a good idea, but it should be specific to Hive and we should carefully consider naming to make it clear.

@vanliu-tx
Copy link
Contributor Author

Does it only work in Hivecatalog? If so, would it be better to name 'hive.filter-iceberg-table' or 'hive.show-iceberg-table-only'?

yes, only in HiveCatalog, will change the name for better understanding.

@rdblue
Copy link
Contributor

rdblue commented Jan 18, 2022

Thanks, @vanliu-tx. Looking close to ready. I think you just need to rename the property.

@vanliu-tx
Copy link
Contributor Author

Thanks, @vanliu-tx. Looking close to ready. I think you just need to rename the property.

I was on vacation yesterday, sorry for the delay.

@vanliu-tx
Copy link
Contributor Author

@rdblue could you help to merge this PR?

@rdblue rdblue merged commit e1c8016 into apache:master Jan 24, 2022
@rdblue
Copy link
Contributor

rdblue commented Jan 24, 2022

Thanks, @vanliu-tx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants