Core: Fix NAN_VALUE_COUNTS serialization for ContentFile #14721
Merged
+40
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpk234
approved these changes
Dec 1, 2025
Contributor
singhpk234
left a comment
There was a problem hiding this comment.
Nice catch @huaxingao, LGTM !
if possible a UT would be really helpful to future proof it
ebyhr
approved these changes
Dec 1, 2025
nastra
approved these changes
Dec 1, 2025
Contributor
|
@huaxingao should we get this out with 1.10.1? |
Contributor
Author
|
@nastra I will cherry-pick this to 1.10.x |
huaxingao
added a commit
to huaxingao/iceberg
that referenced
this pull request
Dec 6, 2025
(cherry picked from commit b35c7ec)
huaxingao
added a commit
that referenced
this pull request
Dec 6, 2025
thomaschow
pushed a commit
to thomaschow/iceberg
that referenced
this pull request
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.