REST: Fix serde of tasks with multiple deletes #14573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Adding this to milestone 1.10.1 for now please feel free to remove if this can wait. |
huaxingao
approved these changes
Nov 12, 2025
ebyhr
approved these changes
Nov 13, 2025
core/src/test/java/org/apache/iceberg/rest/responses/TestPlanTableScanResponseParser.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/iceberg/rest/responses/TestPlanTableScanResponseParser.java
Outdated
Show resolved
Hide resolved
5dcbc4b to
5f3ea49
Compare
nastra
reviewed
Nov 13, 2025
core/src/main/java/org/apache/iceberg/rest/TableScanResponseParser.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Nov 13, 2025
core/src/test/java/org/apache/iceberg/rest/responses/TestPlanTableScanResponseParser.java
Outdated
Show resolved
Hide resolved
7a9dd8d to
0a393ab
Compare
amogh-jahagirdar
approved these changes
Nov 13, 2025
Contributor
Author
|
Thanks @huaxingao @ebyhr @nastra @amogh-jahagirdar for reviews ! |
sfc-gh-prsingh
added a commit
to singhpk234/iceberg
that referenced
this pull request
Nov 13, 2025
Co-authored-by: Prashant Kumar Singh <prashant.singh@snowflake.com>
nastra
pushed a commit
that referenced
this pull request
Nov 13, 2025
Co-authored-by: Prashant Kumar Singh <prashant.singh@snowflake.com>
thomaschow
pushed a commit
to thomaschow/iceberg
that referenced
this pull request
Jan 19, 2026
Co-authored-by: Prashant Kumar Singh <prashant.singh@snowflake.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the change
Extracts the another bug fix extract from #13400 this was discovered when adding E2E test, essentially when calculating the delete file index this should be scoped in per file scan task where on collecting the deletes we reverse lookup to find its index and it should cleared, there is an E2E test for this in #13400
Testing
Adding UT for this