-
Notifications
You must be signed in to change notification settings - Fork 3k
Core: Fix overflow due to default value on timestamp nanos #14359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
approved these changes
Oct 17, 2025
nandorKollar
approved these changes
Oct 17, 2025
huaxingao
approved these changes
Oct 17, 2025
manuzhang
reviewed
Oct 17, 2025
| if (json.has(defaultField)) { | ||
| return Expressions.lit(SingleValueParser.fromJson(type, json.get(defaultField))); | ||
| Object value = SingleValueParser.fromJson(type, json.get(defaultField)); | ||
| if (type instanceof Types.TimestampNanoType) { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add some comments here?
singhpk234
approved these changes
Oct 17, 2025
Contributor
Author
|
Can any of the maintainers rerun the canceled job and merge this PR? |
ebyhr
added a commit
to ebyhr/iceberg
that referenced
this pull request
Nov 6, 2025
) (cherry picked from commit e268df6)
Contributor
Author
|
I sent a backport PR #14513 since this is marked as 1.10.1 milestone. |
nastra
pushed a commit
that referenced
this pull request
Nov 6, 2025
thomaschow
pushed a commit
to thomaschow/iceberg
that referenced
this pull request
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iceberg throws exceptions if JSON contains default values on timestamp nanos: