Skip to content

Conversation

@danielcweeks
Copy link
Contributor

A recent AWS SDK version update introduced Log4j version that are incompatible with some environments (like Spark 4.x). This results in class conflicts if the bundle jar is resolved before other logging jars.

The bom should not include the logging libraries and the existing exclusions don't cover all of the artifacts. This PR expands the exclusions to remove the conflicting dependencies.

Copy link
Contributor

@amogh-jahagirdar amogh-jahagirdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danielcweeks , looks right to me. Tested this out locally too and don't hit any no such method failures from log4j. This feels like a good thing to also get in for 1.10.1 as well.
Also, doesn't look like LICENSE need to be updated but do we also need to update the NOTICE here https://github.com/apache/iceberg/blob/main/aws-bundle/NOTICE#L295 ?

@danielcweeks
Copy link
Contributor Author

Thanks @danielcweeks , looks right to me. Tested this out locally too and don't hit any no such method failures from log4j. This feels like a good thing to also get in for 1.10.1 as well. Also, doesn't look like LICENSE need to be updated but do we also need to update the NOTICE here https://github.com/apache/iceberg/blob/main/aws-bundle/NOTICE#L295 ?

I think there are still a couple classes that are relocated and the notice does say "optionally" so I don't think we need an update here.

@amogh-jahagirdar
Copy link
Contributor

I'll go ahead and merge, thanks @danielcweeks and @singhpk234 @huaxingao for reviewing.

@amogh-jahagirdar amogh-jahagirdar merged commit 5c6629e into apache:main Sep 30, 2025
42 checks passed
gabeiglio pushed a commit to gabeiglio/iceberg that referenced this pull request Oct 1, 2025
@FANNG1
Copy link

FANNG1 commented Oct 11, 2025

Is there any plan to cherry-pick this fix to 1.9 1.10 branch?

@nastra nastra added this to the Iceberg 1.10.1 milestone Oct 15, 2025
adawrapub pushed a commit to adawrapub/iceberg that referenced this pull request Oct 16, 2025
huaxingao pushed a commit to huaxingao/iceberg that referenced this pull request Nov 2, 2025
huaxingao pushed a commit that referenced this pull request Nov 3, 2025
thomaschow pushed a commit to thomaschow/iceberg that referenced this pull request Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants