-
Notifications
You must be signed in to change notification settings - Fork 3k
Core: Batch load new files when validating replaced partitions #13556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+48
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42f0f83 to
4a0dd13
Compare
…herryPick operation and deprecate newFiles
4a0dd13 to
dcbecc6
Compare
bryanck
reviewed
Jul 16, 2025
bryanck
reviewed
Jul 16, 2025
bryanck
approved these changes
Aug 12, 2025
Contributor
bryanck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
amogh-jahagirdar
approved these changes
Aug 12, 2025
Contributor
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gabeiglio , and @bryanck for reviewing!
fbertsch
pushed a commit
to fbertsch/iceberg
that referenced
this pull request
Jan 19, 2026
…ons (apache#13556) - 1.4 (apache#824) Optimize memory utilization by batching new files load when validating a cherry-pick Co-authored-by: Gabriel Igliozzi <gaboiglio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes ensures that data files are not loaded all into memory at once when validating replaced partitions. Instead it uses
ParallelIterableto load new files in batches with a hard limit of 30k files in memory at a time.This PR deprecates
SnapshotUtil.newFilesin favor ofSnapshotUtil.newFilesBetween