Skip to content

Common: Reduce visibility of deprecated method since 1.7.0 #13053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RussellSpitzer merged 1 commit into from
May 14, 2025
Merged

Common: Reduce visibility of deprecated method since 1.7.0 #13053

RussellSpitzer merged 1 commit into from
May 14, 2025

Conversation

@ajantha-bhat
Copy link
Member

@ajantha-bhat ajantha-bhat commented May 14, 2025

No description provided.

ajantha-bhat
ajantha-bhat commented May 14, 2025
View reviewed changes
common/src/main/java/org/apache/iceberg/common/DynConstructors.java
}

/**
* @deprecated since 1.7.0, visibility will be reduced in 1.8.0
Copy link
Member Author

@ajantha-bhat ajantha-bhat May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have done this in 1.8.0 itself I guess.

@ajantha-bhat ajantha-bhat requested review from manuzhang and nastra May 14, 2025 12:43
@ajantha-bhat ajantha-bhat mentioned this pull request May 14, 2025
Closed
3 tasks
@ajantha-bhat
Copy link
Member Author

ajantha-bhat commented May 14, 2025

Flakytest : #12889

TestRewriteDataFilesAction > testParallelPartialProgressWithMaxFailedCommitsLargerThanTotalFileGroup() > formatVersion = 2 FAILED
    java.lang.RuntimeException: partial-progress.enabled is true but 1 rewrite commits failed. This is more than the maximum allowed failures of 0. Check the logs to determine why the individual commits failed. If this is persistent it may help to increase partial-progress.max-commits which will split the rewrite operation into smaller commits.
        at org.apache.iceberg.spark.actions.RewriteDataFilesSparkAction.doExecuteWithPartialProgress(RewriteDataFilesSparkAction.java:342)
        at org.apache.iceberg.spark.actions.RewriteDataFilesSparkAction.execute(RewriteDataFilesSparkAction.java:172)
        at org.apache.iceberg.spark.actions.TestRewriteDataFilesAction.testParallelPartialProgressWithMaxFailedCommitsLargerThanTotalFileGroup(TestRewriteDataFilesAction.java:1345)

@ajantha-bhat ajantha-bhat reopened this May 14, 2025
@RussellSpitzer RussellSpitzer merged commit cb33ec1 into apache:main May 14, 2025
78 of 86 checks passed
@RussellSpitzer
Copy link
Member

RussellSpitzer commented May 14, 2025

Merged, Thanks @ajantha-bhat for the pr. Thanks @nastra and @manuzhang for reviewing!

devendra-nr pushed a commit to devendra-nr/iceberg that referenced this pull request Dec 8, 2025
@ajantha-bhat @devendra-nr
Common: Reduce visibility of deprecated method since 1.7.0 (apache#13053
888f47f 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nastra nastra nastra approved these changes

@RussellSpitzer RussellSpitzer RussellSpitzer approved these changes

@manuzhang manuzhang manuzhang approved these changes

Assignees

No one assigned

Labels

common

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ajantha-bhat @RussellSpitzer @nastra @manuzhang