ORC: Support timestamp(9), variant, and unknown in generics #12567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvary
reviewed
Mar 19, 2025
| static final String ICEBERG_FIELD_LENGTH = "iceberg.length"; | ||
|
|
||
| /** | ||
| * The name of the ORC {@link TypeDescription} attribute indicating the Iceberg timestamp unit. |
Contributor
There was a problem hiding this comment.
nit: the two descriptions are mixed up (iceberg.timestamp-unit, iceberg.struct-type)
Contributor
Author
There was a problem hiding this comment.
Fixed. Thanks for catching this!
pvary
approved these changes
Mar 19, 2025
Contributor
pvary
left a comment
There was a problem hiding this comment.
Found only a minor javadoc issue
Contributor
Author
|
Thanks for reviewing, @pvary! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.