Spec: Allow Equality Deletes with Row Lineage and Define Behavior #12230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenzwu
reviewed
Feb 12, 2025
pvary
reviewed
Feb 12, 2025
36c95ae to
5a9a136
Compare
5a9a136 to
de26c13
Compare
Member
Author
|
@stevenzwu , @pvary + @singhpk234 - Wording Updated |
singhpk234
approved these changes
Feb 12, 2025
Contributor
singhpk234
left a comment
There was a problem hiding this comment.
LGTM ! Thank you @RussellSpitzer !
stevenzwu
approved these changes
Feb 12, 2025
Contributor
stevenzwu
left a comment
There was a problem hiding this comment.
LGTM.
To me, this is just a different wording of essentially the same result. Row lineage is still broken and has a different semantics for updates made via equality deletes.
pvary
reviewed
Feb 13, 2025
pvary
approved these changes
Feb 20, 2025
Fokko
approved these changes
Feb 20, 2025
huaxingao
approved these changes
Feb 20, 2025
rdblue
approved these changes
Feb 20, 2025
aokolnychyi
reviewed
Feb 21, 2025
Member
Author
|
Merged! Thanks everyone - @aokolnychyi , @rdblue , @huaxingao , @Fokko , @pvary , @stevenzwu , @singhpk234 for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.