Flink: make FLIP-27 default in SQL and mark the old FlinkSource as deprecated #11345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenzwu
commented
Oct 17, 2024
| ConfigOptions.key("table.exec.iceberg.use-flip27-source") | ||
| .booleanType() | ||
| .defaultValue(false) | ||
| .defaultValue(true) |
Contributor
Author
There was a problem hiding this comment.
this is the default config change. only applied to 1.20
pvary
reviewed
Oct 18, 2024
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| @Experimental |
Contributor
There was a problem hiding this comment.
Do we want to say that this is PublicEvolving instead?
Contributor
Author
There was a problem hiding this comment.
I feel it is fine to be just public.
pvary
approved these changes
Oct 18, 2024
Contributor
Author
|
thanks @pvary for the review |
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
czy006
pushed a commit
to czy006/iceberg
that referenced
this pull request
Apr 2, 2025
…precated (apache#11345) (cherry picked from commit 2ac5c43)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL config default change is only applied to 1.20.
See the dev ML discussion here.