Flink: add 1.20 support and remove 1.17 #10881
Conversation
also fixed the bug of missing jmh in the 1.19 module.
| Types.NestedField.required(9, "name9", Types.StringType.get())); | ||
|
|
||
| private static final SortOrder SORT_ORDER = SortOrder.builderFor(SCHEMA).asc("id").build(); | ||
| private static final Comparator<StructLike> SORT_ORDER_COMPARTOR = |
There was a problem hiding this comment.
there was jmh setup issue (not included) in 1.19. hence the code issue wasn't caught earlier.
| configuration.set(CoreOptions.CHECK_LEAKED_CLASSLOADER, false); | ||
| configuration.set(RestOptions.BIND_PORT, "0"); | ||
| configuration.set(JobManagerOptions.SLOT_REQUEST_TIMEOUT, 5000L); | ||
| configuration.set(JobManagerOptions.SLOT_REQUEST_TIMEOUT, Duration.ofSeconds(5)); |
There was a problem hiding this comment.
Flink changed the config option type from long to Duration
|
Hi @stevenzwu Is it possible to keep the original commits and authors in the newly introduced flink1.20 , so that people could easily to track how was the current version iterated ? |
@openinx yes, we don't do 
|
...0/flink/src/jmh/java/org/apache/iceberg/flink/sink/shuffle/MapRangePartitionerBenchmark.java
Show resolved
Hide resolved
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java
Show resolved
Hide resolved
|
thanks @pvary for the review. Did |
) This is a follow-up to #10881
…che#10888) This is a follow-up to apache#10881
…che#10888) This is a follow-up to apache#10881 (cherry picked from commit a3cbdcb)
…che#10888) This is a follow-up to apache#10881 (cherry picked from commit a3cbdcb)
The 4th commit has the real change. also fixed jmh setup issue in 1.19 before.