Core: Fix NPE during conflict handling of NULL partitions #10680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partition values can be NULLs, or we can have NULLs because of the VOID transforms. If a conflict is found in such partitions we get a NullPointerException instead of a proper error message.
deniskuzZ
reviewed
Jul 11, 2024
Member
|
Closing and repoening PR to trigger CI build. The current failure is unrelated. |
ajantha-bhat
approved these changes
Jul 12, 2024
jbonofre
approved these changes
Jul 12, 2024
Member
|
It looks good to me indeed. |
Fokko
approved these changes
Jul 12, 2024
Contributor
Fokko
left a comment
There was a problem hiding this comment.
Thanks for fixing this @boroknagyz, thanks for adding this to the milestone @ajantha-bhat, and thanks for the review @ajantha-bhat & @jbonofre
nastra
reviewed
Jul 12, 2024
core/src/test/java/org/apache/iceberg/TestReplacePartitions.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
Fokko
reviewed
Jul 12, 2024
core/src/test/java/org/apache/iceberg/TestReplacePartitions.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jul 12, 2024
Contributor
|
Thanks for fixing this @boroknagyz , and thanks for the review @ajantha-bhat, @jbonofre, @deniskuzZ and @nastra |
jasonf20
pushed a commit
to jasonf20/iceberg
that referenced
this pull request
Aug 4, 2024
* Core: Fix NPE during conflict handling of NULL partitions Partition values can be NULLs, or we can have NULLs because of the VOID transforms. If a conflict is found in such partitions we get a NullPointerException instead of a proper error message. * Fix style issues * Use String.valueOf() * Reduce visibility of constant Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com> * Indentation * Update core/src/main/java/org/apache/iceberg/util/PartitionSet.java --------- Co-authored-by: Fokko Driesprong <fokko@apache.org> Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
* Core: Fix NPE during conflict handling of NULL partitions Partition values can be NULLs, or we can have NULLs because of the VOID transforms. If a conflict is found in such partitions we get a NullPointerException instead of a proper error message. * Fix style issues * Use String.valueOf() * Reduce visibility of constant Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com> * Indentation * Update core/src/main/java/org/apache/iceberg/util/PartitionSet.java --------- Co-authored-by: Fokko Driesprong <fokko@apache.org> Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partition values can be NULLs, or we can have NULLs because of the VOID transforms. If a conflict is found in such partitions we get a NullPointerException instead of a proper error message.