Skip to content

Conversation

@ebyhr
Copy link
Contributor

@ebyhr ebyhr commented Jun 15, 2024

JdbcCatalog.listNamespaces returned unexpected namespaces because of LIKE with %.

The updated testListNamespace test fails without this change:

    List<Namespace> nsp1 = catalog.listNamespaces(Namespace.of("db"));
    assertThat(nsp1).hasSize(3);

Expected size: 3 but was: 4 in:
[db.ns1, db.ns2, db.ns3, db2.ns4]
java.lang.AssertionError: 
Expected size: 3 but was: 4 in:
[db.ns1, db.ns2, db.ns3, db2.ns4]

Fixes #10213

@github-actions github-actions bot added the core label Jun 15, 2024
@ebyhr ebyhr force-pushed the ebi/jdbc-list-namespaces branch from 409a74e to a865bce Compare June 15, 2024 02:49
@nastra nastra added this to the Iceberg 1.6.0 milestone Jun 26, 2024
@nastra
Copy link
Contributor

nastra commented Jul 5, 2024

@ebyhr thanks for working on this and it would be great to get this into 1.6.0.

@ebyhr ebyhr force-pushed the ebi/jdbc-list-namespaces branch from a865bce to 516bc42 Compare July 5, 2024 08:00
@ebyhr
Copy link
Contributor Author

ebyhr commented Jul 5, 2024

Addressed comments. Sorry for my late response. Iceberg IntelliJ project somehow broke after sending this PR.

@Fokko Fokko merged commit d9dbb75 into apache:main Jul 12, 2024
@Fokko
Copy link
Contributor

Fokko commented Jul 12, 2024

Thanks @ebyhr for working on this 👍 Thanks @findepi and @jbonofre for the review

@ebyhr ebyhr deleted the ebi/jdbc-list-namespaces branch July 12, 2024 10:39
jasonf20 pushed a commit to jasonf20/iceberg that referenced this pull request Aug 4, 2024
…e#10498)

* Core: Exclude unexpected namespaces JdbcCatalog.listNamespaces

* Swap order

* Swap it back

---------

Co-authored-by: Fokko Driesprong <fokko@apache.org>
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
…e#10498)

* Core: Exclude unexpected namespaces JdbcCatalog.listNamespaces

* Swap order

* Swap it back

---------

Co-authored-by: Fokko Driesprong <fokko@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Iceberg rest catalog with postgres - List namespaces with parent returns wrong children namespaces

5 participants