AWS: Retain Glue Catalog table description after updating Iceberg table

[aajisaka]

Problem

In AWS Glue Catalog, user can set arbitrary description to the table and its columns via Web UI or even from Amazon Athena. However, the descriptions will be removed after upgrading the table.

What this PR do

This patch is to keep the original table description when calling UpdateTable API. Keeping column description is hard and I think we can open a different PR to do this.

Testing

Manually tested. Also, added an integration test and it passed on my environment.

[geruh]

Awesome, thanks for contributing this @aajisaka! Manually did this change work? For adding some tests, if the unit test logic in this module is difficult. I'd suggest leveraging this modules integration test workflow to update an created table with the glue client directly.

https://github.com/apache/iceberg/blob/main/aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java

[aajisaka]

Thank you for your suggestion @geruh

I'll test this patch manually and update the class.

[aajisaka]

I ran the integration test using my AWS account and the testUpdateTable() was successful.

export AWS_TEST_ACCOUNT_ID=<test account id>
export AWS_REGION=<test region>
export AWS_TEST_BUCKET=<test bucket>
 ./gradlew :iceberg-aws:integrationTest

[aajisaka]

Also, I built the jars and manually tested on AWS Glue as a Spark runtime.

[aajisaka]

Hi @geruh would you review this PR?

[aajisaka]

Hi @geruh @amogh-jahagirdar would you review the latest change?

[amogh-jahagirdar]

Overall looks great @aajisaka, just some nits and then I think it's good to merge!

[geruh]

Awesome work @aajisaka, looks good to me!

[aajisaka]

Thank you @geruh @amogh-jahagirdar