Core: Add property to disable table initialization for JdbcCatalog #10124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
reviewed
Apr 11, 2024
6a40f22 to
0115a15
Compare
nastra
reviewed
Apr 12, 2024
nastra
reviewed
Apr 12, 2024
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Apr 12, 2024
0115a15 to
6bb9fb7
Compare
Contributor
Author
|
Thanks for the review and suggestions @nastra! I believe I've addressed all the feedback in the latest commit |
Contributor
Member
|
This PR is ok for me. I will prepare another pr to provide create statement as sql file and document it. |
nastra
reviewed
Apr 15, 2024
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Apr 15, 2024
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java
Outdated
Show resolved
Hide resolved
nastra
approved these changes
Apr 15, 2024
Contributor
nastra
left a comment
There was a problem hiding this comment.
LGTM, but would be good to address the nits
6bb9fb7 to
2d096e8
Compare
jbonofre
approved these changes
Apr 15, 2024
nastra
approved these changes
Apr 15, 2024
Contributor
|
@mrcnc looks like there's a merge conflict. Can you rebase please? |
2d096e8 to
928e52a
Compare
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be helpful to disable the creation of the catalog tables used by the JdbcCatalog to maintain the principle of least privilege. In my scenario, I would like to perform database migrations with a migration tool using a user with DDL privileges and use a separate user with only DML privileges for connecting the JdbcCatalog to the database.