[spark] Add sparksql alter table partial support for set/remove table properties #2437
Conversation
|
flink ut failed with |
| throw e | ||
| } | ||
| case e: UnsupportedOperationException => | ||
| throw new IllegalArgumentException(e) |
There was a problem hiding this comment.
Just throw the original UnsupportedOperationException.
|
|
||
| override def alterTable(ident: Identifier, changes: TableChange*): Table = { | ||
| throw new UnsupportedOperationException("Altering table is not supported") | ||
| if ( |
There was a problem hiding this comment.
Since toFlussTableChanges will match the supported TableChange, here we don't have to check them first.
| checkAnswer(sql("SHOW DATABASES"), Row(DEFAULT_DATABASE) :: Nil) | ||
| } | ||
|
|
||
| test("Catalog: set/remove table properties") { |
There was a problem hiding this comment.
Maybe it'll be nice to have a separate SparkTableChangeTest, which includes all Alter Table tests.
| assert( | ||
| flussTable.getCustomProperties.toMap.asScala.getOrElse("key1", "non-exists") == "value1") | ||
|
|
||
| sql(s"ALTER TABLE t SET TBLPROPERTIES('key1' = 'value2')") |
There was a problem hiding this comment.
Add cases which set/unset more than one table properties.
| assert( | ||
| flussTable.getCustomProperties.toMap.asScala.getOrElse("key1", "non-exists") == "value1") | ||
|
|
||
| sql(s"ALTER TABLE t SET TBLPROPERTIES('key1' = 'value2')") |
There was a problem hiding this comment.
There must be some table properties which can't be changed, e.g. table.datalake.format, I guess. Think about this case, and update this pr. @wuchong maybe can give some advice.
There was a problem hiding this comment.
+1 for adding a test that sets table.* properties. Currently, only table.datalake.format can be altered, and the cluster must be configured with the datalake.format setting.
|
@Yohahaha left some comments here, and I suggest to simplify this title to |
wuchong
left a comment
There was a problem hiding this comment.
Hi @Yohahaha, I agree with @YannByron's comments. Could you please update the pull request to address them?
Purpose
Linked issue: close #xxx
Brief change log
As title.
Tests
Catalog: set/remove table propertiesinorg.apache.fluss.spark.SparkCatalogTestAPI and Format
Documentation