Merge pull request sveltejs#1822 from aphitiel/sveltejsgh-1743

move resize handler from _beforecreate to _after.. (fixes sveltejs#1743)

Author: Rich-Harris

src/compile/render-dom/wrappers/Element/index.ts

@@ -529,7 +529,7 @@ export default class ElementWrapper extends Wrapper {
 				renderer.hasComplexBindings = true;
 
 				block.builders.hydrate.addLine(
-					`#component.root._beforecreate.push(${handler});`
+					`#component.root._aftercreate.push(${handler});`
 				);
 			}
 		});

test/helpers.js

@@ -48,6 +48,8 @@ export function tryToReadFile(file) {
 export const virtualConsole = new jsdom.VirtualConsole();
 const { window } = new jsdom.JSDOM('<main></main>', {virtualConsole});
 global.document = window.document;
+global.getComputedStyle = window.getComputedStyle;
+global.navigator = {userAgent: 'fake'};
 
 export function env() {
 	window._svelteTransitionManager = null;

test/js/samples/bind-width-height/expected.js

@@ -12,7 +12,7 @@ function create_main_fragment(component, ctx) {
 		c() {
 			div = createElement("div");
 			div.textContent = "some content";
-			component.root._beforecreate.push(div_resize_handler);
+			component.root._aftercreate.push(div_resize_handler);
 		},
 
 		m(target, anchor) {

test/runtime/samples/onupdate-after-concreate-using-bind-offsetWidth/_config.js

@@ -0,0 +1,8 @@
+export default {
+	'skip-ssr': true,
+
+	test(assert, component, target) {
+		assert.ok(component.onstateRanBeforeOncreate);
+		assert.ok(!component.onupdateRanBeforeOncreate);
+	}
+};

test/runtime/samples/onupdate-after-concreate-using-bind-offsetWidth/main.html

@@ -0,0 +1,17 @@
+<div bind:offsetWidth=width></div>
+<script>
+	export default {
+		onstate() {
+			this.onstateRan = true;
+		},
+
+		onupdate() {
+			this.onupdateRan = true;
+		},
+
+		oncreate() {
+			this.onstateRanBeforeOncreate = this.onstateRan;
+			this.onupdateRanBeforeOncreate = this.onupdateRan;
+		}
+	};
+</script>