Merge branch 'test-sveltejsgh-1743' into sveltejsgh-1743

Author: aphitiel

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Svelte changelog
 
+## 2.15.1
+
+* Don't throw missing store error when store is declared in component ([#1828](https://github.com/sveltejs/svelte/issues/1828))
+
 ## 2.15.0
 
 * Event modifiers ([#1088](https://github.com/sveltejs/svelte/issues/1088))

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "svelte",
-  "version": "2.15.0",
+  "version": "2.15.1",
   "description": "The magical disappearing UI framework",
   "main": "compiler/svelte.js",
   "bin": {

package.json

@@ -152,7 +152,7 @@ export default function dom(
 			if (!options || (!options.target && !options.root)) {
 				throw new Error("'target' is a required option");
 			}`}
-			${storeProps.length > 0 && deindent`
+			${storeProps.length > 0 && !templateProperties.store && deindent`
 			if (!options.store) {
 				throw new Error("${debugName} references store properties, but no store was provided");
 			}`}

src/compile/render-dom/index.ts

@@ -115,7 +115,7 @@ export default function ssr(
 			${templateProperties.store && `options.store = %store();`}
 			__result.addComponent(${name});
 
-			${options.dev && storeProps.length > 0 && deindent`
+			${options.dev && storeProps.length > 0 && !templateProperties.store && deindent`
 				if (!options.store) {
 					throw new Error("${debugName} references store properties, but no store was provided");
 				}

src/compile/render-ssr/index.ts

@@ -48,6 +48,8 @@ export function tryToReadFile(file) {
 export const virtualConsole = new jsdom.VirtualConsole();
 const { window } = new jsdom.JSDOM('<main></main>', {virtualConsole});
 global.document = window.document;
+global.getComputedStyle = window.getComputedStyle;
+global.navigator = {userAgent: 'fake'};
 
 export function env() {
 	window._svelteTransitionManager = null;

test/helpers.js

@@ -0,0 +1,5 @@
+export default {
+	compileOptions: {
+		dev: true
+	}
+};

test/runtime/samples/dev-accept-declarative-store/_config.js

@@ -0,0 +1,11 @@
+<p>{$foo}</p>
+
+<script>
+import { Store } from '../../../../store.js';
+
+const store = new Store({ foo : "foo" });
+
+export default {
+	store : () => store,
+};
+</script>

test/runtime/samples/dev-accept-declarative-store/main.html

@@ -0,0 +1,8 @@
+export default {
+	'skip-ssr': true,
+
+	test(assert, component, target) {
+		assert.ok(component.onstateRanBeforeOncreate);
+		assert.ok(!component.onupdateRanBeforeOncreate);
+	}
+};

test/runtime/samples/dev-error-missing-store/_config.js test/runtime/samples/dev-error-missing-store-option/_config.js

@@ -0,0 +1,17 @@
+<div bind:offsetWidth=width></div>
+<script>
+	export default {
+		onstate() {
+			this.onstateRan = true;
+		},
+
+		onupdate() {
+			this.onupdateRan = true;
+		},
+
+		oncreate() {
+			this.onstateRanBeforeOncreate = this.onstateRan;
+			this.onupdateRanBeforeOncreate = this.onupdateRan;
+		}
+	};
+</script>