Skip to content

test(multiple): rework whenStable usages #30878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 16, 2025

We have some really old tests that were depending on fixture.whenStable even though they don't need to. These changes clean them up.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Apr 16, 2025
@crisbeto crisbeto requested a review from a team as a code owner April 16, 2025 08:06
@crisbeto crisbeto requested review from adolgachev and andrewseguin and removed request for a team April 16, 2025 08:06
We have some really old tests that were depending on `fixture.whenStable` even though they don't need to. These changes clean them up.
@crisbeto crisbeto force-pushed the when-stable-remove branch from 2eb2434 to 9666698 Compare April 16, 2025 19:10
@crisbeto crisbeto changed the title test(multiple): remove whenStable usages from tests test(multiple): rework whenStable usages Apr 16, 2025
@crisbeto crisbeto removed the request for review from adolgachev April 16, 2025 19:10
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 16, 2025
@crisbeto crisbeto merged commit 357cfd3 into angular:main Apr 16, 2025
24 checks passed
@crisbeto
Copy link
Member Author

The changes were merged into the following branches: main, 19.2.x

crisbeto added a commit that referenced this pull request Apr 16, 2025
We have some really old tests that were depending on `fixture.whenStable` even though they don't need to. These changes clean them up.

(cherry picked from commit 357cfd3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants