fix(@schematics/angular): set explicit type in library schematic #30045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly sets an empty `type` when the `library` calls into the `component` schematic for a few reasons: 1. The `type` for classes mostly makes sense in an application contenxt. E.g. libraries are unlikely to have guards. 2. The generated component is there primarily as an example and library authors are likely to either delete it or modify it to match their expected public API. 3. It ensures that the generated files remain correect if the `component` schematic ends up inheriting the `type` from the workspace.
crisbeto
commented
Apr 7, 2025
clydin
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly sets an empty
typewhen thelibrarycalls into thecomponentschematic for a few reasons:typefor classes mostly makes sense in an application contenxt. E.g. libraries are unlikely to have guards.componentschematic ends up inheriting thetypefrom the workspace.