add private properties of base-element to amp.extern #3628
Conversation
src/base-element.js
Outdated
There was a problem hiding this comment.
|
@cramforce PTAL. wasn't sure how to refer to the types in an extern, couldn't get the relative paths to the types to work. |
build-system/amp.extern.js
Outdated
There was a problem hiding this comment.
this will prevent closure compiler from renaming the properties. right now theres a chance that these properties if renamed will have a collision with a renamed property in the extension (symbol reuse).
There was a problem hiding this comment.
we're only really worried about BaseElement, since its the only code that travels across compilation units
There was a problem hiding this comment.
@dvoytenko This is special because the extensions subclass a class from a different compilation unit.
There was a problem hiding this comment.
I see. That's pretty annoying. So, actually, none of these vars are really needed there. We can easily delegate these methods to the element instance as most of methods do now. Not sure why I singled out these properties to be honest :)
|
LGTM |
src/base-element.js
Outdated
There was a problem hiding this comment.
nit: The warning art seems to be broken.
There was a problem hiding this comment.
haha i think its that way, i used the star wars font for it
No description provided.