Skip to content

Conversation

@JoelRegus
Copy link
Contributor

…nction

window.context.observeIntersection was not returning a function, the user cannot remove the observeIntersection event listener without this function.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@JoelRegus
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

const initialIntersection = window.context.initialIntersection;
window.context.observeIntersection = cb => {
observeIntersection(cb);
let unlisten = observeIntersection(cb);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll have to be a const.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the note, I've made the change.

@cramforce
Copy link
Member

Ick. LGTM

@JoelRegus Do you need this to go to prod quickly or is the normal schedule OK?

@cramforce cramforce merged commit 24f6ac6 into ampproject:master May 2, 2016
@joel-moat
Copy link

This issue is affecting our ability to measure viewability, it would be great if this change could go out as soon as possible.

Thanks @cramforce!

@cramforce
Copy link
Member

@erwinmombay If we respin canary, we should take this in.

@erwinmombay
Copy link
Member

@cramforce will do one late today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants