-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Fix issue where observeIntersection was not returning the unlisten fu… #3060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where observeIntersection was not returning the unlisten fu… #3060
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
3p/integration.js
Outdated
| const initialIntersection = window.context.initialIntersection; | ||
| window.context.observeIntersection = cb => { | ||
| observeIntersection(cb); | ||
| let unlisten = observeIntersection(cb); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This'll have to be a const.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the note, I've made the change.
|
Ick. LGTM @JoelRegus Do you need this to go to prod quickly or is the normal schedule OK? |
|
This issue is affecting our ability to measure viewability, it would be great if this change could go out as soon as possible. Thanks @cramforce! |
|
@erwinmombay If we respin canary, we should take this in. |
|
@cramforce will do one late today |
…nction
window.context.observeIntersection was not returning a function, the user cannot remove the observeIntersection event listener without this function.