Redirect-avoidance through AMP-side click measurement. #2969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
To @dvoytenko for review. |
ads/alp/handler.js
Outdated
Contributor
There was a problem hiding this comment.
We're already guaranteed a href by the closest predicate function.
bd9128b to
7d4bdae
Compare
ads/alp/handler.js
Outdated
Member
There was a problem hiding this comment.
return object can also be nullable undefined with line 101
Introduces a redirect-avoidance mechanism that enables referrers to track a link invocation without an intermediate redirect by passing a URL to AMP via a fragment param. This change is experiment guarded. Also introduces a small new binary for use on the referrer side (e.g. inside of an ad creative) that helps with constructing the respectives URLs and preconnects to AMP. Primary implementation of ampproject#2934
Member
Author
|
PTAL |
| linkRel.rel = 'preload'; | ||
| linkRel.setAttribute('as', 'script'); | ||
| linkRel.href = | ||
| 'https://cdn.ampproject.org/rtv/01$internalRuntimeVersion$/v0.js'; |
Member
There was a problem hiding this comment.
just always prod? or should read getMode().version?
Member
Author
There was a problem hiding this comment.
Yeah, although I did want to ping you for whether I can get the correct prefix (00, 01, etc.) at runtime in this binary. Doesn't have to be finished in this PR, though.
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a redirect-avoidance mechanism that enables referrers to track a link invocation without an intermediate redirect by passing a URL to AMP via a fragment param. This change is experiment guarded.
Also introduces a small new binary for use on the referrer side (e.g. inside of an ad creative) that helps with constructing the respective URLs and preconnects to AMP.
Primary implementation of #2934