Updated amp-fill-content to workaround IOS #2502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
css/amp.css
Outdated
| display: block; | ||
| width: 100%; | ||
| min-width: 100%; | ||
| width: 1px; |
Contributor
There was a problem hiding this comment.
We don't need width: 1px, but let's also add max-width: 100% - i checked, that works correctly. Please also add a comment and reference https://bugs.webkit.org/show_bug.cgi?id=155198 to explain why we are doing it.
Contributor
|
Thanks a lot, @omegdadi! I left to requests. PTAL. |
Contributor
|
@omegdadi Thanks! LGTM. Could you please squash the commits and I can then merge. |
This commit addresses the issue described here: ampproject#2491
Author
|
NP...squashed. |
Contributor
|
Awesome! Will merge when green. Thanks again! |
dvoytenko
added a commit
that referenced
this pull request
Mar 10, 2016
Updated amp-fill-content to workaround IOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the issue described here: #2491