Remove MAPLIST_FLAG_NO_DEFAULT misuses

[asherkin]

These two base plugins are using the MAPLIST_FLAG_NO_DEFAULT when they shouldn't, which causes much user (and SM developer) confusion as it is completely counter to the documentation.

Raised by @DoctorOcsid on Discord.

[Headline]

If my understanding is correct, the removal of that flag doesn't even change the behavior since sm_map menu points to default in the configurations correct?

[asherkin]

These 2 currently have a separate file specified:

sourcemod/configs/maplists.cfg

Lines 30 to 40 in 17700e4

	/* Admin menu, map menu */
	"sm_map menu"
	{
	"file" "addons/sourcemod/configs/adminmenu_maplist.ini"
	}
	/* Admin menu, map voting menu */
	"sm_votemap menu"
	{
	"file" "addons/sourcemod/configs/adminmenu_maplist.ini"
	}

The problem is that upon removal of that configuration (or if that file can't be loaded), they fall back to loading all the maps rather than the documented behaviour of try "default" then "mapcyclefile".

There is indeed no out-of-the-box behaviour change from this PR though.

[Headline]

lgtm 🍻