Add ArrayStack.Clear native #1676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The ArrayList.Clear code I copied is here. |
peace-maker
approved these changes
Jan 3, 2022
Member
peace-maker
left a comment
There was a problem hiding this comment.
This looks good, thank you.
Usually I'd ask for a use case where this feature was needed, but in this case mirroring ArrayList.Clear doesn't add any maintenance burden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide an ArrayStack.Clear method since this really has no reason not to exist.
Left out the non-methodmap native since I was told it wasn't needed.
I didn't write a test plugin since because ArrayStack just uses a CellArray under the hood, this completely re-uses the code from ArrayList.Clear. I assume that's ok?