Added cookie methodmap (clientprefs)

[JoinedSenses]

This PR adds a methodmap for clientprefs cookies without breaking changes, considering that the cookie Handle is not always the first param for clientprefs functions.

[JoinedSenses]

If there is a better solution for handling the methods where the Handle is not the first param, please let me know.

[psychonic]

If there is a better solution for handling the methods where the Handle is not the first param, please let me know.

I think for other similar cases, we did the same shim but on the C++ side to give us more flexibility for future.

[JoinedSenses]

Happen to have any examples? I spent an hour or two digging for similar cases, but couldnt find anything, although good chance I overlooked it.

By doing it on C++ side, how would it be handled? Creating a new native callback specifically for the methodmap?

[psychonic]

Yeah, you'd create a native that just either calls the other native (similar to what you did), or one that calls the same internal function that the other native wraps (with the difference in parameters).

f020b56 is an example

[JoinedSenses]

Merge conflict existing due to moving typedef to top of inc, allowing it to be defined for the methodmap.

[Headline]

Just one little comment, I'll be happy to merge after that change

Nice work! 🎉

[Headline]

can you mark this const?

this along with the others

[JoinedSenses]

Should this then be made const as well, the commit change I used for reference? https://github.com/alliedmodders/sourcemod/blob/master/core/smn_keyvalues.cpp#L1107

[Headline]

Yes please!

[JoinedSenses]

Addressed 60e2a30

[JoinedSenses]

Tested with:

#include <sourcemod>
#include <clientprefs>

Cookie g_hTestCookie;

public void OnPluginStart() {
	RegAdminCmd("sm_testcookie", cmdTestCookie, ADMFLAG_ROOT);

	g_hTestCookie = new Cookie("TestCookie", "", CookieAccess_Private);
}

public Action cmdTestCookie(int client, int args) {
	if (!client) {
		return Plugin_Handled;
	}

	Cookie testcookie = Cookie.Find("TestCookie");
	PrintToChat(client, "%sFound", testcookie == null ? "Not " : "");
	delete testcookie;

	g_hTestCookie.Set(client, "TestValue");
	CreateTimer(5.0, timerCookie, GetClientUserId(client));
	return Plugin_Handled;
}

Action timerCookie(Handle timer, int userid) {
	int client = GetClientOfUserId(userid);
	if (!client) {
		return Plugin_Continue;
	}

	char buffer[10];
	g_hTestCookie.Get(client, buffer, sizeof(buffer));

	PrintToChat(client, "Result: %s", buffer);
	PrintToChat(client, "Time: %i", g_hTestCookie.GetClientTime(client));
	PrintToChat(client, "Level: %i", g_hTestCookie.AccessLevel);
	return Plugin_Continue;
}

Results:

Found
Result: TestValue
Time: 1559265624
Level: 2

[Headline]

Thanks!