Skip to content

Conversation

@mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Jan 22, 2026

Issue #, if available: #5852

Description of changes:

  • All double keywords loops (do... while/ do... until) should be handled for matching/folding/indenting
  • Removed wrong fold widget on Exit... constructions
  • Fix: not return Ranges case when cursor is in between of two keywords like End if

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

@mkslanc mkslanc changed the title improve VBScript folding logic: handle double keywords Fix: improve VBScript folding logic: handle double keywords Jan 22, 2026
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 92.69406% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.71%. Comparing base (19f426e) to head (32fd491).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/mode/folding/vbscript.js 86.95% 15 Missing ⚠️
src/mode/vbscript.js 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5911      +/-   ##
==========================================
+ Coverage   87.65%   87.71%   +0.06%     
==========================================
  Files         621      621              
  Lines       45591    45768     +177     
  Branches     7592     7624      +32     
==========================================
+ Hits        39963    40146     +183     
+ Misses       5628     5622       -6     
Flag Coverage Δ
unittests 87.71% <92.69%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nightwing nightwing merged commit 33440ff into ajaxorg:master Jan 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants