Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Jan 3, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Documentation:

  • Update type definitions for circle and hexagon convenience functions.

@pull pull bot added the ⤵️ pull label Jan 3, 2025
@pull pull bot merged commit 14d6e43 into admariner:main Jan 3, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 3, 2025

Reviewer's Guide by Sourcery

This pull request replaces the usage of Exclude with Omit in the type definitions for the circle and hexagon functions in the dot.d.ts file. This change aligns the code with the latest TypeScript standards and improves type safety.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Replaced Exclude with Omit in type definitions
  • Changed the type of the options parameter in the circle and hexagon functions from Exclude<DotOptions, \"symbol\"> to Omit<DotOptions, \"symbol\">.
src/marks/dot.d.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@pull pull bot had a problem deploying to github-pages January 3, 2025 23:41 Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant