fix(require-default-prop): avoid requiring defaults for optional props not included in destructuring #2768
+77
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2767
If this approach doesn't align with the project's direction, please don't hesitate to reject this proposal. In that case, you may also close the corresponding issue.
What type of PR is this?
bug fix / enhancement
What does this PR do? / Why do we need it?
This PR fixes a regression in the
vue/require-default-prop
rule introduced in v10.1.0. The rule was requiring default values for ALL optional props when using props destructuring, even if those props were not included in the destructuring pattern.Before this fix
After this fix
What changes did you make? (Give an overview)
Modified
lib/rules/require-default-prop.js
:utils.getPropsDestructure(node)
to get destructured props and check if optional prop existsUpdated test cases in
tests/lib/rules/require-default-prop.js
:Which issue(s) does this PR fix?
Fixes #2767
Related to #2725 and #2741
Additional context
This change maintains backward compatibility and only reduces false positive warnings. The rule continues to work as expected for:
withDefaults()
(still works)The fix specifically addresses the user feedback that the previous fix was too aggressive and made Vue 3.5's props destructuring unnecessarily verbose.