Skip to content

[ONNX] Delete deprecated TS related contents #3425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

titaiwangms
Copy link
Contributor

@titaiwangms titaiwangms commented Jun 30, 2025

Fixes #3420

Description

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @justinchuby @xadupre

Copy link

pytorch-bot bot commented Jun 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3425

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 5 Unrelated Failures

As of commit 79579a7 with merge base 4eed2ab (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@titaiwangms titaiwangms marked this pull request as ready for review June 30, 2025 23:37
@AlannaBurke
Copy link
Contributor

Can you please add a redirect for any deleted tutorials? https://github.com/pytorch/tutorials/blob/main/redirects.py

titaiwangms and others added 2 commits June 30, 2025 23:55
Cpp extension link update
@@ -10,12 +10,6 @@

**Author**: `Ti-Tai Wang <https://github.com/titaiwangms>`_, `Justin Chu <[email protected]>`_, `Thiago Crepaldi <https://github.com/thiagocrepaldi>`_.

.. note::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep this note. All ONNX tutorial should be using the new way: torch.onnx.export(..., dynamo=True)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the page was labeled to audit because of the note mentioning TorchScript? Are you suggesting keep the note but re-write the content?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but now that I read it, I'm thinking it's okay to keep mentioning. I would rephrase though to something like:

  • torch.onnx.export is the outdated way that uses a no longer supported TorchScript and is not recommended.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyTorch Tutorial Audit - ONNX
5 participants