-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[ONNX] Delete deprecated TS related contents #3425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3425
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 5 Unrelated FailuresAs of commit 79579a7 with merge base 4eed2ab ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Can you please add a redirect for any deleted tutorials? https://github.com/pytorch/tutorials/blob/main/redirects.py |
Cpp extension link update
@@ -10,12 +10,6 @@ | |||
|
|||
**Author**: `Ti-Tai Wang <https://github.com/titaiwangms>`_, `Justin Chu <[email protected]>`_, `Thiago Crepaldi <https://github.com/thiagocrepaldi>`_. | |||
|
|||
.. note:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep this note. All ONNX tutorial should be using the new way: torch.onnx.export(..., dynamo=True)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the page was labeled to audit because of the note mentioning TorchScript? Are you suggesting keep the note but re-write the content?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but now that I read it, I'm thinking it's okay to keep mentioning. I would rephrase though to something like:
torch.onnx.export
is the outdated way that uses a no longer supported TorchScript and is not recommended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Fixes #3420
Description
Checklist
cc @justinchuby @xadupre