summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlvaro Herrera2022-09-08 09:16:09 +0000
committerAlvaro Herrera2022-09-08 09:20:29 +0000
commit12d40d4a8d0495cf2c7b564daa8aaa7f107a6c56 (patch)
treec221b6227f17d21894b86fa308651f5079350db9
parentcb62d0b3c372350b997733f41283cc35a6814024 (diff)
Fix perltidy breaking perlcritic
perltidying a "##no critic" line moves the marker to where it becomes useless. Put the line back to how it was, and protect it from further malfeasance. Per buildfarm member crake.
-rw-r--r--src/backend/catalog/Catalog.pm6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/backend/catalog/Catalog.pm b/src/backend/catalog/Catalog.pm
index 4a9fa3b2cb..1546e1b335 100644
--- a/src/backend/catalog/Catalog.pm
+++ b/src/backend/catalog/Catalog.pm
@@ -315,8 +315,10 @@ sub ParseData
# We're treating the input line as a piece of Perl, so we
# need to use string eval here. Tell perlcritic we know what
# we're doing.
- eval '$hash_ref = '
- . $_; ## no critic (ProhibitStringyEval)
+ #<<< protect next line from perltidy
+ # so perlcritic annotation works
+ eval '$hash_ref = ' . $_; ## no critic (ProhibitStringyEval)
+ #>>>
if (!ref $hash_ref)
{
die "$input_file: error parsing line $.:\n$_\n";