diff options
Diffstat (limited to 'src/backend/executor/nodeAgg.c')
| -rw-r--r-- | src/backend/executor/nodeAgg.c | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/src/backend/executor/nodeAgg.c b/src/backend/executor/nodeAgg.c index 5247929667..9e7543ac85 100644 --- a/src/backend/executor/nodeAgg.c +++ b/src/backend/executor/nodeAgg.c @@ -497,6 +497,15 @@ advance_transition_function(AggState *aggstate, * If pass-by-ref datatype, must copy the new value into aggcontext and * pfree the prior transValue. But if transfn returned a pointer to its * first input, we don't need to do anything. + * + * It's safe to compare newVal with pergroupstate->transValue without + * regard for either being NULL, because we below take care to set + * transValue to 0 when NULL. Otherwise we could end up accidentally not + * reparenting, when the transValue has the same numerical value as + * newVal, despite being NULL. This is a somewhat hot path, making it + * undesirable to instead solve this with another branch for the common + * case of the transition function returning its (modified) input + * argument. */ if (!peraggstate->transtypeByVal && DatumGetPointer(newVal) != DatumGetPointer(pergroupstate->transValue)) @@ -508,6 +517,16 @@ advance_transition_function(AggState *aggstate, peraggstate->transtypeByVal, peraggstate->transtypeLen); } + else + { + /* + * Ensure that pergroupstate->transValue ends up being 0, so we + * can safely compare newVal/transValue without having to check + * their respective nullness. + */ + newVal = (Datum) 0; + } + if (!pergroupstate->transValueIsNull) pfree(DatumGetPointer(pergroupstate->transValue)); } |