summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGreg Sabino Mullane2009-04-07 23:08:18 +0000
committerGreg Sabino Mullane2009-04-07 23:08:18 +0000
commit2b09fa5574f2b140e8d9d32d0eb6768c4d42060c (patch)
treee6000ace3395ba0fd7c7e41142eb5c8f98f950d5
parent27a701f514ecb9fab4891575aa86ca98d47ccb03 (diff)
Make Perl::Critic happy.
-rw-r--r--.perlcriticrc7
-rwxr-xr-xcheck_postgres.pl4
2 files changed, 9 insertions, 2 deletions
diff --git a/.perlcriticrc b/.perlcriticrc
index cb7a7da2c..1de41f254 100644
--- a/.perlcriticrc
+++ b/.perlcriticrc
@@ -27,19 +27,25 @@ stop_words = Mullane Nagios Slony nols salesrep psql dbname postgres USERNAME us
[-ErrorHandling::RequireCheckingReturnValueOfEval]
[-ErrorHandling::RequireUseOfExceptions]
[-InputOutput::ProhibitBacktickOperators]
+[-InputOutput::RequireBracedFileHandleWithPrint]
[-InputOutput::RequireBriefOpen]
[-InputOutput::RequireCheckedSyscalls]
[-Lax::ProhibitEmptyQuotes::ExceptAsFallback]
+[-Miscellanea::ProhibitUnrestrictedNoCritic]
+[-Miscellanea::ProhibitUselessNoCritic]
[-Miscellanea::RequireRcsKeywords]
[-Modules::ProhibitExcessMainComplexity]
[-Modules::RequireExplicitInclusion]
+[-NamingConventions::Capitalization]
[-NamingConventions::ProhibitAmbiguousNames]
[-NamingConventions::ProhibitMixedCaseVars]
[-References::ProhibitDoubleSigils]
[-RegularExpressions::ProhibitCaptureWithoutTest]
+[-RegularExpressions::ProhibitComplexRegexes]
[-RegularExpressions::ProhibitEnumeratedClasses]
[-RegularExpressions::ProhibitEscapedMetacharacters]
[-RegularExpressions::ProhibitUnusualDelimiters]
+[-RegularExpressions::RequireDotMatchAnything]
[-RegularExpressions::RequireExtendedFormatting]
[-RegularExpressions::RequireLineBoundaryMatching]
[-Subroutines::ProhibitCallsToUndeclaredSubs]
@@ -60,4 +66,5 @@ stop_words = Mullane Nagios Slony nols salesrep psql dbname postgres USERNAME us
[-Variables::ProhibitPackageVars]
[-Variables::ProhibitPunctuationVars]
[-Variables::RequireInitializationForLocalVars]
+[-Variables::RequireLocalizedPunctuationVars]
[-Variables::RequireLexicalLoopIterators]
diff --git a/check_postgres.pl b/check_postgres.pl
index 221927431..220e84d5a 100755
--- a/check_postgres.pl
+++ b/check_postgres.pl
@@ -1663,7 +1663,7 @@ sub verify_version {
## We almost always need the version, so just grab it for any limitation
$SQL = q{SELECT setting FROM pg_settings WHERE name = 'server_version'};
my $oldslurp = $db->{slurp} || '';
- my $info = run_command($SQL, {noverify => 1});
+ $info = run_command($SQL, {noverify => 1});
if (defined $info->{db}[0]
and exists $info->{db}[0]{error}
and defined $info->{db}[0]{error}
@@ -4078,7 +4078,7 @@ sub check_replicate_row {
## Reset for final output
$db = $sourcedb;
- my $slave = 0;
+ $slave = 0;
for my $d (@{$info2->{db}}) {
$slave++;
next if exists $slave{$slave};