Module talk:senseid

From Wiktionary, the free dictionary
Latest comment: 3 years ago by Chuck Entz in topic appearance
Jump to navigation Jump to search

Tag closing

[edit]

@ShakespeareFan00: As far as I can tell, the tag function is only used from Module:senseid/templates (and {{senseid}}), where the tag name is restricted to be li or p and is almost always li. I thought these tags didn't have to be closed, so where are they causing a lint error? Some context where they need to be closed? — Eru·tuon 19:56, 3 February 2021 (UTC)Reply

https://en.wiktionary.org/w/index.php?title=Inkeri&oldid=61727601 here the tag used is P, and the parser says it's unclosed. A number of these senseid's were added recently. On that I added a manual close, but reverted because I wasn't sure where it was supposed to be. Also in general 'self-closed tags wouldn't be appropriate here, as presumably the list item concerned was supposed to include the content following the senseid invocation?ShakespeareFan00 (talk) 09:34, 4 February 2021 (UTC)Reply
@ShakespeareFan00: I tried moving the senseid immediately before text in this edit, but it seems to only fix one of the two cases of the lint error. Why one of them is bad but the other isn't, I don't know. Something about the {{wikipedia}} preceding {{senseid}} makes it okay apparently. — Eru·tuon 10:22, 4 February 2021 (UTC)Reply
I am not sure what's going on, but unclosed HTML tags are generally not a good idea. On some entries I'd implemented a {{senseid-close}} placed after the end of the relevant content, as a temporary solution, but ideally it should be solved in the relevant templates, or module. ShakespeareFan00 (talk) 10:51, 5 February 2021 (UTC)Reply

appearance

[edit]

I removed the senseid template from the unio page for cosmetic reasons, as it seems an odd choice for us to present a blank line as a definition. It's not clear how to get text to be associated with the linked definition, if it is possible at all ... but either way it's odd for us to link only to something near the target, instead of linking to the target, so I figured we were probably better off without the template altogether. Is there a better way to use this? Thanks, Soap 23:20, 14 April 2021 (UTC)Reply

@Soap This is a very widespread problem, so removing it here or there isn't the answer. There's a workaround: add |tag=p. That doesn't solve the larger problem, but at least it's better than removing a useful template over something that will eventually be fixed. Chuck Entz (talk) 04:55, 15 April 2021 (UTC)Reply
Okay thanks, but could we edit Template:senseid so that it says that? Or do we expect to have this problem end soon? Soap 14:44, 15 April 2021 (UTC)Reply
Well its displaying properly now ... what I saw mightve just been a blip .... and that had occurred to me even then, but I saw no recent edits to either the template or the module, so I figured i'd bring it up. Soap 16:03, 16 April 2021 (UTC)Reply
@Soap It was due to a change in the mediawiki software, as you will see in the discussion at the Grease pit. A patch was added to fix it after the problem was brought to their attention. The temporary |tag=p fix should now be changed back since it has undesirable side-effects. Chuck Entz (talk) 17:08, 17 April 2021 (UTC)Reply