Template talk:Medway watermills diagram

About Template Overflows

Message moved from User talk:Pldx1

There is a problem with the diagram now. Your edit has caused it to finish at Farleigh Lock. I've resisted the temptation to revert you. Please try to fix in the next 24h or I will restore the diagram back to the original pending a fix. Mjroots (talk) 09:36, 22 March 2016 (UTC)[reply]

Continuation

Dear User:Mjroots. You left me a message on my talk page. I am replying here because your message underlines a problem that goes far beyond individuals. Your are totally right when being infuriating when a template you created and maintained across the years, starting 2009, becomes messed because someone modified something somewhere without taking care of the consequences. But... I am not the culprit ! Here are the statuses as of now (Tue 22 March 2016) of the previous revisions of Template:Medway_watermills_diagram. Here, * means template overflow, N don't compile, Y is OK.

oldid	date	ok?	user	m	size	diff	comment
711264393	21:15, 21 March 2016	*	User:Pldx1		20,676	-2	to mouth is uCONTf
711264393	21:12, 21 March 2016	*	User:Pldx1		20,678	-64	applying the "full written solution"
706454642	12:08, 23 February 2016	*	User:Pldx1		20,742	-2	In use. But needs fixing.
610535232	19:37, 28 May 2014	*	User:YLSS	m	20,744	-24	rm dupl
610533560	19:23, 28 May 2014	*	User:YLSS		20,768	+2,677	upper, middle, lower, main !
610519647	17:30, 28 May 2014	N	User:YLSS		18,091	-396	upd links + new icons, simplify, + {{{lower}}}
610515066	16:52, 28 May 2014	N	User:YLSS		18,487	-93,853	rv - not like this, save me!
554374151	00:38, 10 May 2013	Y	User:Frietjes		112,340	+25	without summary
554152652	16:39, 8 May 2013		User:Frietjes		112,315	+47	without summary
554152373	16:37, 8 May 2013		User:Frietjes	m	112,268	0	Frietjes moved page Medway_watermills_diagram to Template:Medway_watermills_diagram
554151748	16:32, 8 May 2013		User:Frietjes		112,268	-31,647	without summary
554151261	16:29, 8 May 2013		User:Frietjes		143,915	+125,477	fixing problem which is causing this to appear in Category:Pages_where_template_include_size_is_exceeded
429739987	15:52, 18 May 2011		User:Mjroots	m	18,438	0	moved Medway_watermills/Diagram to Medway_watermills_diagram: Better title, subpages not enabled in mainspace
414404107	09:17, 17 February 2011		User:Mjroots		18,438	+48	add mill
***	2009-2011		User:Mjroots				(modifs + answers to bots)
304840276	08:13, 29 July 2009		User:Mjroots		7,001	+7,001	Create subpage

When I applied my modifications, I have checked the results of {{Medway_watermills_diagram|part=1}} where part is one of main, upper, lower, middle. And I haven't see any problem (but maybe, I am wrong, and I would be ashamed of that). On the contrary, I have also seen that the whole map (all=1) was on overflow, and that its rendering stopped somewhere. But, remember, I am here because I crossed this file at Category:Pages where template include size is exceeded: I haven't be surprised that removing a simple if structure hasn't be enough to step back below the overflow boundary. Nevertheless and at your demand, I will investigate further to see why even the 19:23, 28 May 2014 version, by User:YLSS, has turned on overflow. In any case, stepping back to any prior version wouldn't fix the problem. Best regards. Pldx1 (talk) 13:18, 22 March 2016 (UTC)[reply]

@Pldx1: Thanks for this. I'm sure we can get it worked out eventually. Mjroots (talk) 13:40, 22 March 2016 (UTC)[reply]

Dear User:Mjroots. I have investigated further. If we want that Template:Medway_watermills_diagram goes back beyond the Template include size limit (while not moving to {{routemap}}), we have to

Using BS-table instead of BS-map
Replacing the BSn and BSn-2 by their old counterparts

And thereafter either:

killing three BSn lines
or replacing five BS3 by their BSrow expansions.

We are near the limit ! Pldx1 (talk) 12:05, 23 March 2016 (UTC)[reply]

And now the solution: replace all the {{BSrow}} in the BSn by their 2014 expression and the Post-expand include size becomes: 2090898/2097152 bytes. Obviously, I am not advocating to do that. The best method to build templates like the Template:Medway watermills diagram is rather to write separately each element, in whatever language you please. Here, we have 35 of them, like User:Pldx1/Bs-map/Medway/bloc16. Then you assemble them like in User:Pldx1/Bs-map/Medway/middle/parts that mostly contains

{{BS-map
|title = middle
|inline={{{inline|}}}
|map = 
{{../../bloc15}}{{../../bloc16}}{{../../bloc18}}{{../../bloc20}}{{../../bloc22}}{{../../bloc24}}{{../../bloc25}}
}}

When you are satisfied with the result, you can compile the */parts by substituting the blocs, obtaining a routemap from routemaps, or a a*/src from {{BS-map}}, that can be compiled afterwards into the final {{routemap}}. OK, this requires a grand total of 50 sub-templates: 35 blocs + 5*3 for the (*,*/src,*/parts) relative to each of the 5 flavours (all, main, upper, lower,middle). Better forecast an attrition war around the theme "who has ever seen so many sub-templates ?" Pldx1 (talk) 13:57, 23 March 2016 (UTC)[reply]

If that will fix it, go ahead. What concerns me is that the diagram displays correctly. Mjroots (talk) 16:28, 23 March 2016 (UTC)[reply]