set_magic_quotes_runtime deprecated in PHP 5.3

[sojweb]

In PHP 5.3, the set_magic_quotes_runtime() function in wp-settings.php has been deprecated and gives an error. I propose two ways of addressing this, one to simply suppress the error, another to do a version test. The version test method would be better should the function ever be removed from PHP.

[sojweb]

Meant to add this in the original description: Magic quotes are disabled by default in 5.3, and removed in PHP 6 ​http://us2.php.net/magic_quotes

[sojweb]

This is definitely related to #8701. But given that support will be completely removed for this at some point, playing around with error reporting levels is, at best, a temporary fix. Probably the only way to handle it properly is to break backward compatibility, do version testing, or create the wp-settings.php file at install time with the appropriate code.

[azaozz]

How about testing for "features"? Easy enough to do here:

if ( function_exists('set_magic_quotes_runtime')
    set_magic_quotes_runtime(0);

[jacobsantos]

Replying to azaozz:

How about testing for "features"? Easy enough to do here:

if ( function_exists('set_magic_quotes_runtime')
    set_magic_quotes_runtime(0);

This does not cover deprecated. PHP6 isn't going to be released in a while, so covering support for it now, doesn't seem like a good idea.

[sojweb]

I think I have a better solution; I will post it later today.

[sojweb]

Perhaps a more comprehensive solution here: #8701

[Denis-de-Bernardy]

hasn't this been fixed in trunk via #8701?

[Denis-de-Bernardy]

closing as dup of #8701

[lloydbudd]

#8701 would seem to just hide the issue of using the deprecated function, not fix the issue. Reopening.

$ ack set_magic_quotes_runtime -l
wp-admin/import/blogware.php
wp-admin/import/dotclear.php
wp-admin/import/rss.php
wp-admin/import/textpattern.php
wp-admin/import/wordpress.php
wp-admin/includes/class-pclzip.php
wp-includes/class-phpmailer.php
wp-settings.php

[Denis-de-Bernardy]

in this case it should version compare < 5.3

[mark-k]

Just encountered this issue. caused the firestats plugin not to work because the deprecation notice was output into the JS file it generates on the fly. I would suggest to bump up the priority/severity of this bug.

[nacin]

Why is it outputting JS on the fly? admin-ajax? wp_localize_script?

E_DEPRECATED is silenced by WP. I consider this ticket wontfix.

[Ipstenu]

Looks like it blows up in PHP6 (per hearsay reports - the evidence is circumstantial.)

[nacin]

PHP6 development was moved to a branch some time ago because Unicode support was too difficult to implement. We won't be needing to make a decision on this for a few years.

[azizur]

I am on PHP Version 5.3.5 and it just showed up. Would be nice to have this resolved.

[wonderboymusic]

it would be nice to not have this in the logs on every single request ( when error_reporting(-1) is set )

I don’t understand the hesitance to just switch to ini_set? The next line does it properly:

// Disable magic quotes at runtime. Magic quotes are added using wpdb later in wp-settings.php.
set_magic_quotes_runtime( 0 );
@ini_set( 'magic_quotes_sybase', 0 );

[Viper007Bond]

Fixed in [18549].

[hakre]

Thanks for fixing. Just ran over it, changed a 3.2.1 install, fixed my warning issue.

[natalisilverio]

Hello guys

I was performing a compatibility test with PHP Code Sniffer using PHPCompatibility ​/ PHPCompatibility for migrating to PHP 7 and I've got the errors bellow. Once this error was fixed in [18549] I believe it is something that I do not need to be concerned about. Anyway I wanted to check if anyone had any issue with class-pclzip.php running on a PHP 7.

Thank you

[1mFILE: ...rowdyhouse/crowdyhouse-github/wp-admin/includes/class-pclzip.php[0m
----------------------------------------------------------------------
[1mFOUND 2 ERRORS AFFECTING 2 LINES[0m
----------------------------------------------------------------------
 5345 | [31mERROR[0m | [1mFunction set_magic_quotes_runtime() is deprecated since
      |       | PHP 5.3 and removed since PHP 7.0[0m
      |       | (PHPCompatibility.PHP.DeprecatedFunctions.set_magic_quotes_runtimeDeprecatedRemoved)
 5376 | [31mERROR[0m | [1mFunction set_magic_quotes_runtime() is deprecated since
      |       | PHP 5.3 and removed since PHP 7.0[0m
      |       | (PHPCompatibility.PHP.DeprecatedFunctions.set_magic_quotes_runtimeDeprecatedRemoved)
----------------------------------------------------------------------