Fixed force_ssl_admin to always return bool

[pbearne]

this function can be passed a random string
where the Gobal value set by is used we check if it is not empty
the doc say to set a bool but is allows you set any value eg 'false' which on empty
So I have added a cast to make sure the value set is bool
see pre fix tests
https://core.trac.wordpress.org/ticket/60018

Trac Ticket: Core-60023

## Description

• This pull request addresses a potential issue with the force_ssl_admin function, ensuring that it always returns a boolean value, as intended by its documentation.

## Changes Made

• Modified the force_ssl_admin function to cast the $force parameter to a boolean type. This guarantees that any input, whether it's a string, integer, or null, is converted to a boolean value (true or false).

• Updated the function documentation to clarify that the $force parameter can accept string|bool|null, making it clear to developers what types are acceptable.

## Reasoning

• The original implementation allowed for non-boolean values to be passed to the function, which could lead to unexpected behavior. By explicitly casting to boolean, we ensure consistency and prevent potential bugs caused by improperly handled input.

## Impact

• This change enhances the reliability of the force_ssl_admin function, making it safer to use in various contexts without worrying about the type of input provided.

## Testing

• Confirmed that the function behaves as expected with different input types, including boolean, string, and integer values.

• Validated that the function returns the correct boolean value in all scenarios.

Hi @swissspidy , can you please take a look into this PR. Thanks

Hi @swissspidy , can you please take a look into this PR. Thanks

[swissspidy]

#57262 was marked as a duplicate.

[swissspidy]

Additional props to pbearne, costdev, autotutorial from #57262.

[swissspidy]

#57261 was marked as a duplicate.

Hi @swissspidy , I have left a query, can you please check once. Thanks.