WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#33660 closed defect (bug) (fixed)

#a11y-headings - Theme Editor Page Sub Headings Should be h2 Instead of h3

Reported by: mrahmadawais's profile mrahmadawais Owned by: afercia's profile afercia
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Administration Keywords: has-patch commit
Focuses: accessibility Cc:

Description

#a11y-headings - Theme Editor Page Sub Headings Should be h2 Instead of h3. Only the heading which states the name of template and file E.g. "Twenty Fifteen: Stylesheet (style.css)" heading.

Attachments (2)

33660.patch​ (834 bytes) - added by mrahmadawais 9 years ago.
converts h3 to h2
33660.2.patch​ (1.9 KB) - added by afercia 9 years ago.

Download all attachments as: .zip

Change History (9)

@mrahmadawais
9 years ago

converts h3 to h2

#1 @mrahmadawais
9 years ago

  • Keywords has-patch dev-feedback added

This ticket was mentioned in ​Slack in #accessibility by mrahmadawais. ​View the logs.
9 years ago

#3 @SergeyBiryukov
9 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to afercia
  • Status changed from new to assigned

@afercia
9 years ago

#4 follow-up: @afercia
9 years ago

  • Keywords commit added; dev-feedback removed
  • Version set to 4.3

I think also the "Templates" and "Styles" headings should be changed in <h2>, unless I'm missing something. Refreshed patch.

This ticket was mentioned in ​Slack in #accessibility by afercia. ​View the logs.
9 years ago

#6 in reply to: ↑ 4 @mrahmadawais
9 years ago

Replying to afercia:

I think also the "Templates" and "Styles" headings should be changed in <h2>, unless I'm missing something. Refreshed patch.

Makes a lot of sense. I was not sure about those two, so I let 'em go.

#7 @afercia
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34066:

Bump H3 headings to H2 on the Theme Editor screen for better accessibility.

Props mrahmadawais.
Fixes #33660.

Note: See TracTickets for help on using tickets.