WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#33658 closed defect (bug) (fixed)

#a11y-headings - Add New Category & Tag Headings should be h2 instead of h3

Reported by: mrahmadawais's profile mrahmadawais Owned by: afercia's profile afercia
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch commit
Focuses: accessibility Cc:

Description

#a11y-headings - Sub headings should be h2 instead of h3 at edit page for category and tags. At a glance the headings are "Add New Tag" and "Add New Category"

Attachments (1)

33658.patch​ (964 bytes) - added by mrahmadawais 9 years ago.
converts h3 to h2

Download all attachments as: .zip

Change History (9)

@mrahmadawais
9 years ago

converts h3 to h2

#1 @mrahmadawais
9 years ago

  • Keywords has-patch dev-feedback added

This ticket was mentioned in ​Slack in #accessibility by mrahmadawais. ​View the logs.
9 years ago

#3 @joedolson
9 years ago

  • Keywords commit added; dev-feedback removed
  • Milestone changed from Awaiting Review to 4.4

Patch looks good.

We could preserve the reference to .col-wrap h3, but I don't see any reason to. If anybody else does, make your argument!

#4 @SergeyBiryukov
9 years ago

  • Owner set to afercia
  • Status changed from new to assigned

#5 @wonderboymusic
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33917:

Bump H3 headings to H2 on the {Term} screens for better accessibility.

Props mrahmadawais.
Fixes #33658.

#6 @ryan
9 years ago

  • Keywords needs-screenshots added

#7 @ryan
9 years ago

  • Keywords needs-screenshots removed

I flagged this need-screenshots to double check that visual hierarchy didn't change. Looks good. Removing the tag.

#8 @SergeyBiryukov
9 years ago

In 35130:

Accessibility: Correct the style for Popular Tags header on Edit Tags screen after [33917].

Props afercia.
See #33559. See #33658.

Note: See TracTickets for help on using tickets.