WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#33605 closed defect (bug) (fixed)

#a11y-headings - Add New User page headings

Reported by: cheffheid's profile Cheffheid Owned by: afercia's profile afercia
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Administration Keywords: good-first-bug has-patch commit
Focuses: accessibility Cc:

Description

"Add Existing User" (multisite) and "Add New User" headings need to be bumped up from h3 to h2 and have their CSS changed to look like they did before the heading change.

#a11y-headings

Attachments (2)

33605.patch​ (1.0 KB) - added by Cheffheid 9 years ago.
Heading fix (only appear on multi site installs)
33605.2.patch​ (1.0 KB) - added by afercia 9 years ago.

Download all attachments as: .zip

Change History (12)

#1 @Cheffheid
9 years ago

  • Keywords good-first-bug added

#2 @mrahmadawais
9 years ago

Isn't it already h1. Where are you talking about?

@Cheffheid
9 years ago

Heading fix (only appear on multi site installs)

#3 @Cheffheid
9 years ago

  • Keywords has-patch added

#4 @SergeyBiryukov
9 years ago

  • Milestone changed from Awaiting Review to 4.4

#5 @SergeyBiryukov
9 years ago

  • Keywords commit added
  • Owner set to afercia
  • Status changed from new to assigned

@afercia
9 years ago

#6 @afercia
9 years ago

Tested and verified, refreshed patch rebuilt from the root.

#7 @afercia
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33945:

Bump H3 headings to H2 on the Network Add New User screen for better accessibility.

Props Cheffheid.
Fixes #33605.

#8 @ryan
9 years ago

  • Keywords needs-screenshot added

#9 @ryan
9 years ago

  • Keywords needs-screenshots added; needs-screenshot removed

#10 @ryan
9 years ago

  • Keywords needs-screenshots removed

Momentarily tagged this needs-screenshots to remind me to test for unintended visual hierarchy changes. Watching and testing header changes is a hobby of mine. :-) Looks good, although I didn't exercise all conditionals. Removing tag.

Note: See TracTickets for help on using tickets.